This repository has been archived by the owner on Jun 19, 2022. It is now read-only.
Always pass upgrade test #2059
Merged
Always pass upgrade test #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
/assign @nlopezgi |
|
we're probably going to have to cherry pick this into the 0.20 branch, but lets wait until release automation runs |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlopezgi, zhongduo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
can you add a TODO or issue link, or a comment on why it's there? |
|
/unhold |
zhongduo
pushed a commit
to zhongduo/knative-gcp
that referenced
this pull request
Jan 12, 2021
This reverts commit dc07ee0.
nlopezgi
pushed a commit
to nlopezgi/knative-gcp
that referenced
this pull request
Jan 12, 2021
knative-prow-robot
pushed a commit
that referenced
this pull request
Jan 12, 2021
Co-authored-by: Zhongduo Lin (Jimmy) <[email protected]>
knative-prow-robot
pushed a commit
that referenced
this pull request
Jan 14, 2021
zhongduo
pushed a commit
to zhongduo/knative-gcp
that referenced
this pull request
Jan 14, 2021
* Revert "Always pass upgrade test (google#2059)" This reverts commit dc07ee0. * Use git tag without major version in master to get latest tag
knative-prow-robot
pushed a commit
that referenced
this pull request
Jan 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade test is always failing due to the namespace renaming. Temporarily disable it now.
Need to fix #2020 ASAP.